Conversation
- Restructure README for better readability and clarity - Simplify installation and quick start sections - Streamline features section with clearer organization - Add Auto-Rubric paper (2025-10-20) - Add Taming the Judge paper (2025-10-17) - Remove verbose documentation and consolidate navigation - Update contributing guidelines formatting
- Add blue-to-purple gradient RM-Gallery logo at the top - Move News section before Installation for better visibility - Align with best practices for open source project READMEs
- Create logo.svg with consistent gradient colors (cyan-blue-purple-pink) - Replace README logo with SVG for proper gradient rendering on GitHub - RM gradient: #22d3ee → #3b82f6 → #6366f1 → #8b5cf6 - Gallery gradient: #6366f1 → #8b5cf6 → #a855f7 → #ec4899
- Update logo.svg gradients and spacing to match index.md design - Replace README header logo with shared SVG asset - Use same logo image in docs/index.md for consistent branding
Summary of ChangesHello @XiaoBoAI, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the user experience by simplifying and modernizing the project's documentation. The primary goal is to make the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly simplifies the README.md file, making it more concise and easier for new users to navigate. The introduction of an SVG logo and its use in both the README and the main documentation page is a great improvement for consistency and maintainability. I've added a couple of suggestions to improve the code examples and setup instructions in the new README to ensure they are complete and work as expected for users.
| from rm_gallery.core.reward import BasePointWiseReward | ||
|
|
||
| class CustomReward(BasePointWiseReward): | ||
| def _evaluate(self, sample, **kwargs): | ||
| # Your evaluation logic | ||
| return RewardResult(...) |
There was a problem hiding this comment.
The code example for creating a custom reward model is missing an import for RewardResult. This will cause a NameError if a user tries to run this code. Please add the import to make the example runnable.
| from rm_gallery.core.reward import BasePointWiseReward | |
| class CustomReward(BasePointWiseReward): | |
| def _evaluate(self, sample, **kwargs): | |
| # Your evaluation logic | |
| return RewardResult(...) | |
| from rm_gallery.core.reward import BasePointWiseReward | |
| from rm_gallery.core.reward.schema import RewardResult | |
| class CustomReward(BasePointWiseReward): | |
| def _evaluate(self, sample, **kwargs): | |
| # Your evaluation logic | |
| return RewardResult(...) |
| which will take care of the formatting and linting automatically. | ||
| ```shell | ||
| ```bash | ||
| pip install -e . |
There was a problem hiding this comment.
The pre-commit package needs to be installed for pre-commit install to work. pip install -e . might not install it. Consider adding pip install pre-commit to the instructions to ensure contributors can set up the environment correctly.
2 participants
No description provided.